fix(api): improve Station router - review feedback

- Rinomina _RecipeSummary -> RecipeSummary: il leading underscore
  segnalava "privato" ma la classe e usata come response_model pubblico
  ed esposta nell'OpenAPI schema.
- Aggiunge commento esplicativo sopra /by-code/{code}/recipes sul perche
  l'ordine di dichiarazione conta (protezione gia data dal tipo int di
  station_id, ma esplicito per prevenire regressioni durante refactor).
- Detail message del 404 by-code uniformato a "Station not found"
  (senza distinguere not-found vs inactive, evita leak di esistenza).
- Aggiunge 3 test mancanti sul router:
  * test_admin_can_list_stations (copertura happy path + active_only)
  * test_assign_recipe_not_found_returns_404
  * test_duplicate_assignment_returns_409

Feedback da code-reviewer su Task 5. Full suite: 11/11 passed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-17 22:46:54 +02:00
parent 338f21fba0
commit a79ab37add
3 changed files with 79 additions and 8 deletions
+10 -6
View File
@@ -11,7 +11,7 @@ from schemas.station import (
StationResponse,
StationRecipeAssignmentCreate,
StationRecipeAssignmentResponse,
_RecipeSummary,
RecipeSummary,
)
from services import station_service
@@ -40,7 +40,11 @@ async def create_new_station(
return StationResponse.model_validate(station)
@router.get("/by-code/{code}/recipes", response_model=list[_RecipeSummary])
# NOTE: this literal-prefix route must stay above the /{station_id} routes.
# The int-typed station_id param already guards against "by-code" being
# matched as a station id, but keeping the explicit order avoids surprises
# during refactors (e.g. if someone regroups handlers by HTTP method).
@router.get("/by-code/{code}/recipes", response_model=list[RecipeSummary])
async def list_recipes_by_station_code(
code: str,
user: User = Depends(get_current_user),
@@ -56,10 +60,10 @@ async def list_recipes_by_station_code(
if station is None or not station.active:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail=f"Station '{code}' not found or inactive",
detail="Station not found",
)
recipes = await station_service.list_station_recipes(db, station.id)
return [_RecipeSummary.model_validate(r) for r in recipes]
return [RecipeSummary.model_validate(r) for r in recipes]
@router.get("/{station_id}", response_model=StationResponse)
@@ -95,7 +99,7 @@ async def remove_station(
await station_service.delete_station(db, station_id)
@router.get("/{station_id}/recipes", response_model=list[_RecipeSummary])
@router.get("/{station_id}/recipes", response_model=list[RecipeSummary])
async def list_assigned_recipes(
station_id: int,
admin: User = Depends(require_admin_user),
@@ -103,7 +107,7 @@ async def list_assigned_recipes(
):
"""Admin view: recipes assigned to this station (active only)."""
recipes = await station_service.list_station_recipes(db, station_id)
return [_RecipeSummary.model_validate(r) for r in recipes]
return [RecipeSummary.model_validate(r) for r in recipes]
@router.post(