Adriano
72f0cb1f1b
1. api_client.py: ConnectionError/Timeout restituisce status_code=502 invece
di 0 (nessuna route confrontava == 0, verificato); i proxy che inoltrano
resp.get("status_code", 500) ereditano il fix senza altre modifiche.
4. measure.py lookup_barcode: code non stringa -> 400 (prima 500 su
code.strip()); urllib.parse.quote(code, safe="") prima di comporre l'URL
verso il backend - un barcode con '/' o '../' non spezza più il path né
raggiunge altri GET con i permessi dell'utente.
5. Ogni "'{{ _(...) }}'" dentro un attributo Alpine (x-text, :title,
:placeholder, @click) sostituito con "{{ _(...)|tojson_attr }}": la
traduzione EN di admin/stations.html:105 ("Clear the station's recipes")
ha un apostrofo che l'IT non ha, e rompeva quel binding e basta - non è
un XSS, ma stessa classe di difetto di #10. File toccati: admin/stations,
admin/users, maker/recipe_list, maker/recipe_editor, maker/task_editor,
maker/task_drawing, components/caliper_status, measure/select_recipe.
Le occorrenze dentro <script>...</script> (non attributi) sono fuori
perimetro per questo punto.
6. statistics.py dashboard(): ciclo sulle pagine (per_page=100, il massimo
del backend) invece di un'unica chiamata che troncava la tendina ricette
alla centesima.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
115 lines
3.8 KiB
Python
115 lines
3.8 KiB
Python
"""Tests for statistics blueprint (client/blueprints/statistics.py).
|
|
|
|
Covers dashboard rendering, role enforcement, and SPC/summary API proxies.
|
|
"""
|
|
import pytest
|
|
|
|
|
|
class TestDashboard:
|
|
"""GET /statistics/dashboard tests."""
|
|
|
|
def test_dashboard_renders(self, logged_in_client, mock_api_client):
|
|
"""Dashboard renders for Metrologist role."""
|
|
mock_api_client.get.return_value = {
|
|
"items": [
|
|
{"id": 1, "code": "REC-001", "name": "Recipe A"},
|
|
],
|
|
"total": 1,
|
|
"pages": 1,
|
|
}
|
|
|
|
resp = logged_in_client.get("/statistics/dashboard")
|
|
assert resp.status_code == 200
|
|
|
|
def test_dashboard_requires_login(self, client):
|
|
"""Unauthenticated user is redirected to login."""
|
|
resp = client.get("/statistics/dashboard", follow_redirects=False)
|
|
assert resp.status_code == 302
|
|
assert "/auth/login" in resp.headers["Location"]
|
|
|
|
def test_dashboard_pages_past_the_first_hundred_recipes(
|
|
self, logged_in_client, mock_api_client,
|
|
):
|
|
"""#37.6: a single per_page=100 call used to drop every recipe past #100."""
|
|
page1 = {
|
|
"items": [{"id": i, "code": f"REC-{i:03d}"} for i in range(100)],
|
|
"total": 101,
|
|
"pages": 2,
|
|
}
|
|
page2 = {
|
|
"items": [{"id": 100, "code": "REC-100"}],
|
|
"total": 101,
|
|
"pages": 2,
|
|
}
|
|
mock_api_client.get.side_effect = [page1, page2]
|
|
|
|
resp = logged_in_client.get("/statistics/dashboard")
|
|
assert resp.status_code == 200
|
|
assert mock_api_client.get.call_count == 2
|
|
assert "REC-100" in resp.get_data(as_text=True)
|
|
|
|
first_call = mock_api_client.get.call_args_list[0]
|
|
second_call = mock_api_client.get.call_args_list[1]
|
|
assert first_call.kwargs["params"]["page"] == 1
|
|
assert second_call.kwargs["params"]["page"] == 2
|
|
|
|
|
|
class TestRoleRequired:
|
|
"""Metrologist role enforcement tests."""
|
|
|
|
def test_requires_metrologist_role(self, flask_app):
|
|
"""User without Metrologist role gets 403 on statistics endpoints."""
|
|
with flask_app.test_client() as c:
|
|
with c.session_transaction() as sess:
|
|
sess["api_key"] = "test-key"
|
|
sess["user"] = {
|
|
"id": 3,
|
|
"username": "maker_only",
|
|
"display_name": "Maker Only",
|
|
"roles": ["Maker"],
|
|
"is_admin": False,
|
|
"language_pref": "en",
|
|
"theme_pref": "light",
|
|
"active": True,
|
|
}
|
|
sess["user_id"] = 3
|
|
sess["language"] = "en"
|
|
sess["theme"] = "light"
|
|
|
|
resp = c.get("/statistics/dashboard")
|
|
assert resp.status_code == 403
|
|
|
|
|
|
class TestSPCProxy:
|
|
"""SPC data proxy endpoint tests."""
|
|
|
|
def test_summary_proxy(self, logged_in_client, mock_api_client):
|
|
"""Summary API proxy returns JSON from backend."""
|
|
mock_api_client.get.return_value = {
|
|
"total": 100,
|
|
"pass_count": 90,
|
|
"fail_count": 5,
|
|
"warning_count": 5,
|
|
}
|
|
|
|
resp = logged_in_client.get(
|
|
"/statistics/api/summary?recipe_id=1"
|
|
)
|
|
assert resp.status_code == 200
|
|
data = resp.get_json()
|
|
assert data["total"] == 100
|
|
|
|
def test_capability_proxy(self, logged_in_client, mock_api_client):
|
|
"""Capability API proxy returns JSON from backend."""
|
|
mock_api_client.get.return_value = {
|
|
"cp": 1.33,
|
|
"cpk": 1.20,
|
|
}
|
|
|
|
resp = logged_in_client.get(
|
|
"/statistics/api/capability?recipe_id=1&subtask_id=1"
|
|
)
|
|
assert resp.status_code == 200
|
|
data = resp.get_json()
|
|
assert "cp" in data
|