Adriano Dal Pastro
a159eb2b8b
Punto 7 del documento modifiche del 28/07, terza richiesta di Menoncin.
GET /api/stations ora usa StationWithRecipesResponse, che era gia' definita nello
schema senza che nessun endpoint la usasse. Non costa query in piu':
Station.assignments e' gia' selectin-loaded. In lista compaiono le sole ricette
attive, coerente con cio' che l'operatore vede davvero a quella stazione.
DELETE /api/stations/{id}/recipes azzera le assegnazioni di una stazione senza
eliminarla, cosi' si riassegna da capo. E' idempotente: azzerare una stazione gia'
vuota risponde removed=0, non 404. In tabella e' un pulsante per riga, con
conferma perche' l'azione e' distruttiva.
Il cambio stazione al volo (?station=CODE, override in sessione) serve al
collaudo: senza, provare N stazioni richiede N PC. E' dietro il flag
STATION_SWITCH_ENABLED, default 0. Non e' legato al ruolo admin perche'
/measure/select richiede MeasurementTec, e gatearlo su is_admin avrebbe escluso
proprio chi fa il collaudo. In fabbrica l'identita' della stazione viene
dall'installazione locale, e misurare contro le ricette di un'altra stazione
romperebbe in silenzio la tracciabilita': per questo il codice richiesto e'
validato prima di essere memorizzato - un refuso lascia l'operatore sulla
stazione configurata con un messaggio, invece di incastrarlo su una stazione
inesistente - e quando l'override e' attivo la pagina lo dichiara, con il codice
configurato accanto e un link per ripristinare.
Le traduzioni: pybabel update aveva indovinato dieci voci da stringhe simili
marcandole fuzzy, in entrambi i cataloghi. "Azzera Stazione" era diventato "Crea
Stazione", l'opposto, su un dialogo distruttivo. Non si vedeva perche' la
compilazione salta le fuzzy e ricade sul sorgente italiano, ma sarebbe emerso al
primo build con --use-fuzzy. Tradotte per esteso le 17 stringhe nuove in IT ed EN
e tolti i flag.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
377 lines
12 KiB
Python
377 lines
12 KiB
Python
"""Integration tests for /api/stations endpoints."""
|
|
import pytest
|
|
from httpx import AsyncClient
|
|
|
|
from src.backend.tests.conftest import auth_headers, create_test_recipe
|
|
|
|
|
|
async def test_list_stations_requires_auth(client: AsyncClient):
|
|
resp = await client.get("/api/stations")
|
|
assert resp.status_code == 401
|
|
|
|
|
|
async def test_create_station_as_admin(client: AsyncClient, admin_user):
|
|
resp = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-API", "name": "Via API"},
|
|
)
|
|
assert resp.status_code == 201, resp.text
|
|
body = resp.json()
|
|
assert body["code"] == "ST-API"
|
|
assert body["active"] is True
|
|
assert body["id"] > 0
|
|
|
|
|
|
async def test_create_station_non_admin_is_403(client: AsyncClient, maker_user):
|
|
resp = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(maker_user),
|
|
json={"code": "ST-NO", "name": "No"},
|
|
)
|
|
assert resp.status_code == 403
|
|
|
|
|
|
async def test_update_station(client: AsyncClient, admin_user):
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-UP", "name": "Old"},
|
|
)
|
|
station_id = created.json()["id"]
|
|
resp = await client.put(
|
|
f"/api/stations/{station_id}",
|
|
headers=auth_headers(admin_user),
|
|
json={"name": "New", "active": False},
|
|
)
|
|
assert resp.status_code == 200
|
|
body = resp.json()
|
|
assert body["name"] == "New"
|
|
assert body["active"] is False
|
|
|
|
|
|
async def test_delete_station(client: AsyncClient, admin_user):
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-D", "name": "D"},
|
|
)
|
|
sid = created.json()["id"]
|
|
resp = await client.delete(
|
|
f"/api/stations/{sid}", headers=auth_headers(admin_user),
|
|
)
|
|
assert resp.status_code == 204
|
|
again = await client.get(
|
|
f"/api/stations/{sid}", headers=auth_headers(admin_user),
|
|
)
|
|
assert again.status_code == 404
|
|
|
|
|
|
async def test_assign_and_unassign_recipe(
|
|
client: AsyncClient, admin_user, db_session,
|
|
):
|
|
recipe = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-AS")
|
|
await db_session.commit()
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-ASSIGN", "name": "A"},
|
|
)
|
|
sid = created.json()["id"]
|
|
a = await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
assert a.status_code == 201
|
|
r = await client.get(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
)
|
|
assert r.status_code == 200
|
|
assert [rec["code"] for rec in r.json()] == ["REC-AS"]
|
|
u = await client.delete(
|
|
f"/api/stations/{sid}/recipes/{recipe.id}",
|
|
headers=auth_headers(admin_user),
|
|
)
|
|
assert u.status_code == 204
|
|
r2 = await client.get(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
)
|
|
assert r2.json() == []
|
|
|
|
|
|
async def test_list_recipes_by_station_code(
|
|
client: AsyncClient, admin_user, measurement_tec_user, db_session,
|
|
):
|
|
recipe = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-BC")
|
|
await db_session.commit()
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-BC", "name": "BC"},
|
|
)
|
|
sid = created.json()["id"]
|
|
await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
resp = await client.get(
|
|
"/api/stations/by-code/ST-BC/recipes",
|
|
headers=auth_headers(measurement_tec_user),
|
|
)
|
|
assert resp.status_code == 200
|
|
assert [r["code"] for r in resp.json()] == ["REC-BC"]
|
|
|
|
|
|
async def test_list_recipes_by_unknown_code_404(
|
|
client: AsyncClient, measurement_tec_user,
|
|
):
|
|
resp = await client.get(
|
|
"/api/stations/by-code/ST-DOES-NOT-EXIST/recipes",
|
|
headers=auth_headers(measurement_tec_user),
|
|
)
|
|
assert resp.status_code == 404
|
|
|
|
|
|
async def test_admin_can_list_stations(client: AsyncClient, admin_user):
|
|
await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-L1", "name": "A"},
|
|
)
|
|
await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-L2", "name": "B", "active": False},
|
|
)
|
|
resp = await client.get("/api/stations", headers=auth_headers(admin_user))
|
|
assert resp.status_code == 200
|
|
codes = {s["code"] for s in resp.json()}
|
|
assert {"ST-L1", "ST-L2"}.issubset(codes)
|
|
|
|
resp_active = await client.get(
|
|
"/api/stations?active_only=true", headers=auth_headers(admin_user),
|
|
)
|
|
assert resp_active.status_code == 200
|
|
active_codes = {s["code"] for s in resp_active.json()}
|
|
assert "ST-L1" in active_codes
|
|
assert "ST-L2" not in active_codes
|
|
|
|
|
|
async def test_assign_recipe_not_found_returns_404(
|
|
client: AsyncClient, admin_user,
|
|
):
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-NR", "name": "NR"},
|
|
)
|
|
sid = created.json()["id"]
|
|
resp = await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": 99999},
|
|
)
|
|
assert resp.status_code == 404
|
|
|
|
|
|
async def test_duplicate_assignment_returns_409(
|
|
client: AsyncClient, admin_user, db_session,
|
|
):
|
|
recipe = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-DUP")
|
|
await db_session.commit()
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-DUP-A", "name": "Dup"},
|
|
)
|
|
sid = created.json()["id"]
|
|
first = await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
assert first.status_code == 201
|
|
second = await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
assert second.status_code == 409
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Station list carries assigned recipes (point 7)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
async def test_list_stations_includes_assigned_recipes(
|
|
client: AsyncClient, admin_user, db_session,
|
|
):
|
|
"""The admin list shows which recipes a station handles, without a call per row."""
|
|
recipe = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-LIST")
|
|
await db_session.commit()
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-WITHREC", "name": "Con ricette"},
|
|
)
|
|
sid = created.json()["id"]
|
|
await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
|
|
resp = await client.get("/api/stations", headers=auth_headers(admin_user))
|
|
assert resp.status_code == 200
|
|
station = next(s for s in resp.json() if s["id"] == sid)
|
|
assert [r["code"] for r in station["recipes"]] == ["REC-LIST"]
|
|
|
|
|
|
async def test_list_stations_empty_recipes_when_unassigned(
|
|
client: AsyncClient, admin_user,
|
|
):
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-NOREC", "name": "Senza ricette"},
|
|
)
|
|
sid = created.json()["id"]
|
|
resp = await client.get("/api/stations", headers=auth_headers(admin_user))
|
|
station = next(s for s in resp.json() if s["id"] == sid)
|
|
assert station["recipes"] == []
|
|
|
|
|
|
async def test_list_stations_hides_inactive_recipes(
|
|
client: AsyncClient, admin_user, db_session,
|
|
):
|
|
"""An assigned but deactivated recipe must not show: the operator won't see it."""
|
|
recipe = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-OFF")
|
|
await db_session.commit()
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-INACT", "name": "Con ricetta spenta"},
|
|
)
|
|
sid = created.json()["id"]
|
|
await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
|
|
recipe.active = False
|
|
await db_session.commit()
|
|
|
|
resp = await client.get("/api/stations", headers=auth_headers(admin_user))
|
|
station = next(s for s in resp.json() if s["id"] == sid)
|
|
assert station["recipes"] == []
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Per-row station reset (point 7)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
async def test_reset_station_removes_all_assignments(
|
|
client: AsyncClient, admin_user, db_session,
|
|
):
|
|
first = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-R1")
|
|
second = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-R2")
|
|
await db_session.commit()
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-RESET", "name": "Da azzerare"},
|
|
)
|
|
sid = created.json()["id"]
|
|
for recipe in (first, second):
|
|
await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
|
|
resp = await client.delete(
|
|
f"/api/stations/{sid}/recipes", headers=auth_headers(admin_user),
|
|
)
|
|
assert resp.status_code == 200, resp.text
|
|
assert resp.json() == {"station_id": sid, "removed": 2}
|
|
|
|
left = await client.get(
|
|
f"/api/stations/{sid}/recipes", headers=auth_headers(admin_user),
|
|
)
|
|
assert left.json() == []
|
|
|
|
|
|
async def test_reset_station_keeps_the_station(
|
|
client: AsyncClient, admin_user, db_session,
|
|
):
|
|
"""Reset clears assignments only - the station stays and can be reassigned."""
|
|
recipe = await create_test_recipe(db_session, user_id=admin_user.id, code="REC-KEEP")
|
|
await db_session.commit()
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-KEEP", "name": "Resta"},
|
|
)
|
|
sid = created.json()["id"]
|
|
await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
await client.delete(f"/api/stations/{sid}/recipes", headers=auth_headers(admin_user))
|
|
|
|
still_there = await client.get(
|
|
f"/api/stations/{sid}", headers=auth_headers(admin_user),
|
|
)
|
|
assert still_there.status_code == 200
|
|
|
|
reassigned = await client.post(
|
|
f"/api/stations/{sid}/recipes",
|
|
headers=auth_headers(admin_user),
|
|
json={"recipe_id": recipe.id},
|
|
)
|
|
assert reassigned.status_code == 201
|
|
|
|
|
|
async def test_reset_empty_station_is_idempotent(client: AsyncClient, admin_user):
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-IDEM", "name": "Gia vuota"},
|
|
)
|
|
sid = created.json()["id"]
|
|
resp = await client.delete(
|
|
f"/api/stations/{sid}/recipes", headers=auth_headers(admin_user),
|
|
)
|
|
assert resp.status_code == 200
|
|
assert resp.json()["removed"] == 0
|
|
|
|
|
|
async def test_reset_station_non_admin_is_403(
|
|
client: AsyncClient, admin_user, maker_user,
|
|
):
|
|
created = await client.post(
|
|
"/api/stations",
|
|
headers=auth_headers(admin_user),
|
|
json={"code": "ST-RBAC", "name": "Protetta"},
|
|
)
|
|
sid = created.json()["id"]
|
|
resp = await client.delete(
|
|
f"/api/stations/{sid}/recipes", headers=auth_headers(maker_user),
|
|
)
|
|
assert resp.status_code == 403
|
|
|
|
|
|
async def test_reset_unknown_station_is_404(client: AsyncClient, admin_user):
|
|
resp = await client.delete(
|
|
"/api/stations/999999/recipes", headers=auth_headers(admin_user),
|
|
)
|
|
assert resp.status_code == 404
|