a159eb2b8b
Punto 7 del documento modifiche del 28/07, terza richiesta di Menoncin.
GET /api/stations ora usa StationWithRecipesResponse, che era gia' definita nello
schema senza che nessun endpoint la usasse. Non costa query in piu':
Station.assignments e' gia' selectin-loaded. In lista compaiono le sole ricette
attive, coerente con cio' che l'operatore vede davvero a quella stazione.
DELETE /api/stations/{id}/recipes azzera le assegnazioni di una stazione senza
eliminarla, cosi' si riassegna da capo. E' idempotente: azzerare una stazione gia'
vuota risponde removed=0, non 404. In tabella e' un pulsante per riga, con
conferma perche' l'azione e' distruttiva.
Il cambio stazione al volo (?station=CODE, override in sessione) serve al
collaudo: senza, provare N stazioni richiede N PC. E' dietro il flag
STATION_SWITCH_ENABLED, default 0. Non e' legato al ruolo admin perche'
/measure/select richiede MeasurementTec, e gatearlo su is_admin avrebbe escluso
proprio chi fa il collaudo. In fabbrica l'identita' della stazione viene
dall'installazione locale, e misurare contro le ricette di un'altra stazione
romperebbe in silenzio la tracciabilita': per questo il codice richiesto e'
validato prima di essere memorizzato - un refuso lascia l'operatore sulla
stazione configurata con un messaggio, invece di incastrarlo su una stazione
inesistente - e quando l'override e' attivo la pagina lo dichiara, con il codice
configurato accanto e un link per ripristinare.
Le traduzioni: pybabel update aveva indovinato dieci voci da stringhe simili
marcandole fuzzy, in entrambi i cataloghi. "Azzera Stazione" era diventato "Crea
Stazione", l'opposto, su un dialogo distruttivo. Non si vedeva perche' la
compilazione salta le fuzzy e ricade sul sorgente italiano, ma sarebbe emerso al
primo build con --use-fuzzy. Tradotte per esteso le 17 stringhe nuove in IT ed EN
e tolti i flag.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
182 lines
6.4 KiB
Python
182 lines
6.4 KiB
Python
"""Stations router - CRUD + recipe assignments."""
|
|
from fastapi import APIRouter, Depends, HTTPException, status
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from src.backend.database import get_db
|
|
from src.backend.api.middleware.api_key import get_current_user, require_admin_user
|
|
from src.backend.models.orm.user import User
|
|
from src.backend.models.api.station import (
|
|
StationCreate,
|
|
StationUpdate,
|
|
StationResponse,
|
|
StationRecipeAssignmentCreate,
|
|
StationRecipeAssignmentResponse,
|
|
StationResetResponse,
|
|
StationWithRecipesResponse,
|
|
RecipeSummary,
|
|
)
|
|
from src.backend.services import station_service
|
|
|
|
router = APIRouter(prefix="/api/stations", tags=["stations"])
|
|
|
|
|
|
@router.get("", response_model=list[StationWithRecipesResponse])
|
|
async def list_stations(
|
|
active_only: bool = False,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""List all stations with the recipes assigned to each (admin only).
|
|
|
|
The admin station list shows which products a station handles, so the
|
|
assignments travel with the station instead of needing a call per row.
|
|
Station.assignments is selectin-loaded, so this costs no extra query.
|
|
|
|
Only active recipes are listed, matching what an operator actually sees
|
|
at that station via /by-code/{code}/recipes.
|
|
"""
|
|
stations = await station_service.list_stations(db, active_only=active_only)
|
|
return [
|
|
StationWithRecipesResponse(
|
|
**StationResponse.model_validate(s).model_dump(),
|
|
recipes=sorted(
|
|
(
|
|
RecipeSummary.model_validate(a.recipe)
|
|
for a in s.assignments
|
|
if a.recipe is not None and a.recipe.active
|
|
),
|
|
key=lambda r: r.code,
|
|
),
|
|
)
|
|
for s in stations
|
|
]
|
|
|
|
|
|
@router.post("", response_model=StationResponse, status_code=status.HTTP_201_CREATED)
|
|
async def create_new_station(
|
|
data: StationCreate,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Create a station (admin only)."""
|
|
station = await station_service.create_station(db, data, admin)
|
|
return StationResponse.model_validate(station)
|
|
|
|
|
|
# NOTE: this literal-prefix route must stay above the /{station_id} routes.
|
|
# The int-typed station_id param already guards against "by-code" being
|
|
# matched as a station id, but keeping the explicit order avoids surprises
|
|
# during refactors (e.g. if someone regroups handlers by HTTP method).
|
|
@router.get("/by-code/{code}/recipes", response_model=list[RecipeSummary])
|
|
async def list_recipes_by_station_code(
|
|
code: str,
|
|
user: User = Depends(get_current_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Operator view: active recipes assigned to the station with this code.
|
|
|
|
Used by the Flask client at startup / on select_recipe page.
|
|
Any authenticated user can call this; filtering is by station code from
|
|
the client's STATION_CODE environment variable.
|
|
"""
|
|
station = await station_service.get_station_by_code(db, code)
|
|
if station is None or not station.active:
|
|
raise HTTPException(
|
|
status_code=status.HTTP_404_NOT_FOUND,
|
|
detail="Station not found",
|
|
)
|
|
recipes = await station_service.list_station_recipes(db, station.id)
|
|
return [RecipeSummary.model_validate(r) for r in recipes]
|
|
|
|
|
|
@router.get("/{station_id}", response_model=StationResponse)
|
|
async def get_single_station(
|
|
station_id: int,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Get a station by id (admin only)."""
|
|
station = await station_service.get_station(db, station_id)
|
|
return StationResponse.model_validate(station)
|
|
|
|
|
|
@router.put("/{station_id}", response_model=StationResponse)
|
|
async def update_existing_station(
|
|
station_id: int,
|
|
data: StationUpdate,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Update a station (admin only)."""
|
|
station = await station_service.update_station(db, station_id, data)
|
|
return StationResponse.model_validate(station)
|
|
|
|
|
|
@router.delete("/{station_id}", status_code=status.HTTP_204_NO_CONTENT)
|
|
async def remove_station(
|
|
station_id: int,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Delete a station (admin only). Cascades to assignments."""
|
|
await station_service.delete_station(db, station_id)
|
|
|
|
|
|
@router.get("/{station_id}/recipes", response_model=list[RecipeSummary])
|
|
async def list_assigned_recipes(
|
|
station_id: int,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Admin view: recipes assigned to this station (active only)."""
|
|
recipes = await station_service.list_station_recipes(db, station_id)
|
|
return [RecipeSummary.model_validate(r) for r in recipes]
|
|
|
|
|
|
@router.post(
|
|
"/{station_id}/recipes",
|
|
response_model=StationRecipeAssignmentResponse,
|
|
status_code=status.HTTP_201_CREATED,
|
|
)
|
|
async def assign_recipe_to_station(
|
|
station_id: int,
|
|
data: StationRecipeAssignmentCreate,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Assign a recipe to a station (admin only)."""
|
|
assignment = await station_service.assign_recipe(
|
|
db, station_id, data.recipe_id, admin,
|
|
)
|
|
return StationRecipeAssignmentResponse.model_validate(assignment)
|
|
|
|
|
|
@router.delete("/{station_id}/recipes", response_model=StationResetResponse)
|
|
async def reset_station_recipes(
|
|
station_id: int,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Clear every recipe assignment of a station (admin only).
|
|
|
|
Backs the per-row reset in the admin list: the station is left with no
|
|
recipes and can be reassigned from scratch, without deleting the station
|
|
itself. Idempotent - resetting an already empty station reports removed=0.
|
|
"""
|
|
removed = await station_service.unassign_all_recipes(db, station_id)
|
|
return StationResetResponse(station_id=station_id, removed=removed)
|
|
|
|
|
|
@router.delete(
|
|
"/{station_id}/recipes/{recipe_id}",
|
|
status_code=status.HTTP_204_NO_CONTENT,
|
|
)
|
|
async def unassign_recipe_from_station(
|
|
station_id: int,
|
|
recipe_id: int,
|
|
admin: User = Depends(require_admin_user),
|
|
db: AsyncSession = Depends(get_db),
|
|
):
|
|
"""Remove a recipe assignment (admin only)."""
|
|
await station_service.unassign_recipe(db, station_id, recipe_id)
|