Adriano
1a0431366f
Aligns the repo with the python-project-spec-design.md template chosen for V2.0.0. Big move, no logic changes. The 3 pre-existing test failures (test_recipes::test_update_recipe, test_recipes:: test_recipe_versioning, test_tasks::test_reorder_tasks, plus the client test_save_measurement_proxy) survive unchanged. Layout changes - server/ -> src/backend/ - server/middleware/ -> src/backend/api/middleware/ - server/routers/ -> src/backend/api/routers/ - server/models/ -> src/backend/models/orm/ - server/schemas/ -> src/backend/models/api/ - server/uploads/ -> uploads/ (project root, mounted volume) - server/tests/ -> src/backend/tests/ - client/ -> src/frontend/flask_app/ (Flask kept; React deroga is documented in CLAUDE.md, justified by tablet UX, USB caliper/barcode workflow and Fabric.js integration) Tooling - pyproject.toml: monorepo with [project] core deps and optional-dependencies server / client / dev. Replaces both server/requirements.txt and client/requirements.txt. - uv.lock + .python-version (3.11) committed for reproducible builds. - Dockerfile (root, backend) and Dockerfile.frontend rewritten to use uv sync --frozen --no-dev --extra server|client; legacy Dockerfiles preserved as Dockerfile.legacy for reference but excluded from build context via .dockerignore. - docker-compose.dev.yml + docker-compose.yml: build context now ".", dockerfile pointing to the root files. Code adjustments forced by the move - Every "from config|database|models|schemas|services|routers|middleware import ..." rewritten to its src.backend.* equivalent (50+ files including indented inline imports inside test bodies). - src/backend/migrations/env.py: insert project root into sys.path so alembic can resolve src.backend.* imports regardless of cwd. - src/backend/config.py: env_file ../../.env (was ../.env), upload_path resolves project root via parents[2]. - src/backend/tests/conftest.py + tests: import ... from src.backend.* instead of bare names; old per-directory pytest.ini files removed in favor of root pyproject.toml [tool.pytest.ini_options]. - .gitignore: uploads/ at root, src/frontend/flask_app/static/css/ tailwind.css path; .dockerignore tightened. - CLAUDE.md: rewrote sections "Layout del repository", "Comandi di Sviluppo", "Database & Migrations", "Test", "i18n", and all path references throughout the architecture sections. Verified - uv lock resolves 77 packages; uv sync --extra server --extra client --extra dev installs cleanly. - uv run pytest: 171 passed, 4 pre-existing failures. - uv run alembic -c src/backend/migrations/alembic.ini check loads config and metadata (errors only on the absent local MySQL). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
115 lines
5.3 KiB
Python
115 lines
5.3 KiB
Python
"""Tests for station_service business logic."""
|
|
import pytest
|
|
from fastapi import HTTPException
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from src.backend.models.orm.station import Station
|
|
from src.backend.models.api.station import StationCreate, StationUpdate
|
|
from src.backend.services.station_service import (
|
|
create_station, update_station, delete_station,
|
|
assign_recipe, unassign_recipe, list_station_recipes,
|
|
get_station_by_code,
|
|
)
|
|
from src.backend.tests.conftest import _create_user, create_test_recipe
|
|
|
|
|
|
async def test_create_station_ok(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a1", is_admin=True)
|
|
station = await create_station(
|
|
db_session, StationCreate(code="ST-100", name="Pilot"), admin
|
|
)
|
|
assert station.id is not None
|
|
assert station.code == "ST-100"
|
|
|
|
|
|
async def test_create_station_duplicate_code(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a2", is_admin=True)
|
|
await create_station(db_session, StationCreate(code="ST-DUP", name="A"), admin)
|
|
with pytest.raises(HTTPException) as exc:
|
|
await create_station(db_session, StationCreate(code="ST-DUP", name="B"), admin)
|
|
assert exc.value.status_code == 409
|
|
|
|
|
|
async def test_update_station(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a3", is_admin=True)
|
|
station = await create_station(db_session, StationCreate(code="ST-U", name="Old"), admin)
|
|
updated = await update_station(
|
|
db_session, station.id, StationUpdate(name="New name"),
|
|
)
|
|
assert updated.name == "New name"
|
|
assert updated.code == "ST-U"
|
|
|
|
|
|
async def test_update_missing_station(db_session: AsyncSession):
|
|
with pytest.raises(HTTPException) as exc:
|
|
await update_station(db_session, 9999, StationUpdate(name="x"))
|
|
assert exc.value.status_code == 404
|
|
|
|
|
|
async def test_assign_and_list_recipes(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a4", is_admin=True)
|
|
station = await create_station(db_session, StationCreate(code="ST-R", name="R"), admin)
|
|
r1 = await create_test_recipe(db_session, user_id=admin.id, code="REC-R1")
|
|
r2 = await create_test_recipe(db_session, user_id=admin.id, code="REC-R2")
|
|
await assign_recipe(db_session, station.id, r1.id, admin)
|
|
await assign_recipe(db_session, station.id, r2.id, admin)
|
|
recipes = await list_station_recipes(db_session, station.id)
|
|
assert {r.code for r in recipes} == {"REC-R1", "REC-R2"}
|
|
|
|
|
|
async def test_assign_same_recipe_twice_is_409(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a5", is_admin=True)
|
|
station = await create_station(db_session, StationCreate(code="ST-D", name="D"), admin)
|
|
r = await create_test_recipe(db_session, user_id=admin.id, code="REC-D")
|
|
await assign_recipe(db_session, station.id, r.id, admin)
|
|
with pytest.raises(HTTPException) as exc:
|
|
await assign_recipe(db_session, station.id, r.id, admin)
|
|
assert exc.value.status_code == 409
|
|
|
|
|
|
async def test_unassign_recipe(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a6", is_admin=True)
|
|
station = await create_station(db_session, StationCreate(code="ST-UN", name="UN"), admin)
|
|
r = await create_test_recipe(db_session, user_id=admin.id, code="REC-UN")
|
|
await assign_recipe(db_session, station.id, r.id, admin)
|
|
await unassign_recipe(db_session, station.id, r.id)
|
|
recipes = await list_station_recipes(db_session, station.id)
|
|
assert recipes == []
|
|
|
|
|
|
async def test_get_station_by_code(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a7", is_admin=True)
|
|
await create_station(db_session, StationCreate(code="ST-FIND", name="F"), admin)
|
|
found = await get_station_by_code(db_session, "ST-FIND")
|
|
assert found is not None
|
|
assert found.name == "F"
|
|
missing = await get_station_by_code(db_session, "ST-NOPE")
|
|
assert missing is None
|
|
|
|
|
|
async def test_list_recipes_only_returns_active(db_session: AsyncSession):
|
|
admin = await _create_user(db_session, username="a8", is_admin=True)
|
|
station = await create_station(db_session, StationCreate(code="ST-A", name="A"), admin)
|
|
active = await create_test_recipe(db_session, user_id=admin.id, code="REC-AC")
|
|
inactive = await create_test_recipe(db_session, user_id=admin.id, code="REC-IN")
|
|
inactive.active = False
|
|
await db_session.flush()
|
|
await assign_recipe(db_session, station.id, active.id, admin)
|
|
await assign_recipe(db_session, station.id, inactive.id, admin)
|
|
recipes = await list_station_recipes(db_session, station.id)
|
|
assert [r.code for r in recipes] == ["REC-AC"]
|
|
|
|
|
|
async def test_delete_station_cascades_assignments(db_session: AsyncSession):
|
|
from sqlalchemy import select
|
|
from src.backend.models.orm.station import StationRecipeAssignment
|
|
admin = await _create_user(db_session, username="a9", is_admin=True)
|
|
station = await create_station(db_session, StationCreate(code="ST-DEL", name="D"), admin)
|
|
r = await create_test_recipe(db_session, user_id=admin.id, code="REC-DEL")
|
|
await assign_recipe(db_session, station.id, r.id, admin)
|
|
await delete_station(db_session, station.id)
|
|
remaining = await db_session.execute(
|
|
select(StationRecipeAssignment).where(StationRecipeAssignment.station_id == station.id)
|
|
)
|
|
assert remaining.scalars().all() == []
|