root
f4f4e4efd7
Code review fixes (commit 0c74691):
- _maybe_tickle logs failures via logger.debug instead of silent pass
- _http typed as httpx.AsyncClient | None
- 30s timeout commented (matches Alpaca, IBKR gateway latency)
- _request retries once on 401 with forced LST refresh (spec §4 IBKR_AUTH_FAILED)
- New tests: test_request_retries_once_on_401, test_request_raises_on_persistent_401
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
89 lines
2.7 KiB
Python
89 lines
2.7 KiB
Python
from __future__ import annotations
|
|
|
|
import re
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
from cerbero_mcp.exchanges.ibkr.client import IBKRClient
|
|
from pytest_httpx import HTTPXMock
|
|
|
|
|
|
@pytest.fixture
|
|
def fake_signer():
|
|
s = MagicMock()
|
|
s.consumer_key = "CK"
|
|
s.access_token = "AT"
|
|
s.get_live_session_token = AsyncMock(return_value="LSTBASE64==")
|
|
s.sign_with_lst = MagicMock(return_value="SIG==")
|
|
s.make_oauth_params = MagicMock(return_value={
|
|
"oauth_consumer_key": "CK", "oauth_token": "AT",
|
|
"oauth_nonce": "n", "oauth_timestamp": "1",
|
|
"oauth_signature_method": "HMAC-SHA256", "oauth_version": "1.0",
|
|
})
|
|
return s
|
|
|
|
|
|
@pytest.fixture
|
|
def client(fake_signer):
|
|
return IBKRClient(
|
|
signer=fake_signer,
|
|
account_id="DU1234",
|
|
paper=True,
|
|
base_url="https://api.ibkr.com/v1/api",
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_health_no_network(client):
|
|
info = await client.health()
|
|
assert info["status"] == "ok"
|
|
assert info["paper"] is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_account_summary(httpx_mock: HTTPXMock, client):
|
|
httpx_mock.add_response(
|
|
url=re.compile(r".*/portfolio/DU1234/summary"),
|
|
json={"netliquidation": {"amount": 10000, "currency": "USD"}, "totalcashvalue": {"amount": 8000}},
|
|
)
|
|
httpx_mock.add_response(
|
|
url=re.compile(r".*/tickle"),
|
|
json={"session": "abc"},
|
|
)
|
|
data = await client.get_account()
|
|
assert "netliquidation" in data
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_request_retries_once_on_401(httpx_mock: HTTPXMock, client):
|
|
httpx_mock.add_response(url=re.compile(r".*/tickle"), json={})
|
|
# First call returns 401
|
|
httpx_mock.add_response(
|
|
url=re.compile(r".*/portfolio/DU1234/summary"),
|
|
status_code=401, text="session expired",
|
|
)
|
|
# Second call (after LST refresh) succeeds
|
|
httpx_mock.add_response(
|
|
url=re.compile(r".*/portfolio/DU1234/summary"),
|
|
json={"netliquidation": {"amount": 5000}},
|
|
)
|
|
data = await client.get_account()
|
|
assert data["netliquidation"]["amount"] == 5000
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_request_raises_on_persistent_401(httpx_mock: HTTPXMock, client):
|
|
from cerbero_mcp.exchanges.ibkr.oauth import IBKRAuthError
|
|
httpx_mock.add_response(url=re.compile(r".*/tickle"), json={})
|
|
# Both attempts return 401
|
|
httpx_mock.add_response(
|
|
url=re.compile(r".*/portfolio/DU1234/summary"),
|
|
status_code=401, text="bad creds",
|
|
)
|
|
httpx_mock.add_response(
|
|
url=re.compile(r".*/portfolio/DU1234/summary"),
|
|
status_code=401, text="bad creds",
|
|
)
|
|
with pytest.raises(IBKRAuthError, match="after retry"):
|
|
await client.get_account()
|